Consider nonce when checking for existing vote transactions in stacke… #4621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdb during update_dkg Signed-off-by: Jacinta Ferrant <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4621 +/- ##
==========================================
+ Coverage 77.78% 83.24% +5.45%
==========================================
Files 470 470
Lines 332564 332714 +150
Branches 317 317
==========================================
+ Hits 258690 276952 +18262
+ Misses 73866 55754 -18112
Partials 8 8
... and 214 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
kantai
approved these changes
Apr 3, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue that can occur if a signer account is used to generate stacks transactions external to the signer binary operation. This is not normally an issue unless the created transaction occurs in the same block. Signers should attempt to resubmit a vote if it is found to be unconfirmed (i.e. they have not voted yet) and the tx is still sitting in stackerdb transaction slot with an outdated nonce.
Closes #4615